Hi,
Again, using latest code from git://git.kernel.org/pub/scm/linux/
kernel/git/josh/sparse.git
When I run: make CHECKFLAGS="-D__CHECK_ENDIAN__" C=2 modules
I get this warning:
CHECK fs/ntfs/super.c
fs/ntfs/super.c:3003:2: warning: context imbalance in
'ntfs_fill_super' - unexpected unlock
And ntfs_fill_super does on entry:
unlock_kernel();
And then does "lock_kernel();" on exit.
Which is what causes the warning as the warning goes away if I remove
it...
The unlock+lock was added by Ingo Molnar IIRC because ntfs_fill_super
() was causing a huge latency which is bad for RT code...
It is a perfectly legitimate thing to do as the kernel lock is held
by the VFS but NTFS does not need it as it locks everything
appropriately internally.
What can I do to tell sparse that this code is ok and there should
not be a warning? Is there a "__ignore_context_imbalance" or
something that I can mark up the {un,}lock_kernel() with or something
like that?
Thanks a lot in advance!
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
