Christopher Li wrote: > This patch address some of the dead instruction > left in the usage chain. Merged. One minor style note: > --- sparse.orig/simplify.c 2006-12-21 14:35:18.000000000 -0800 > +++ sparse/simplify.c 2006-12-21 14:35:55.000000000 -0800 > @@ -217,6 +217,11 @@ void kill_instruction(struct instruction > kill_use(&insn->src2); > kill_use(&insn->src3); > return; > + case OP_BR: > + insn->bb = NULL; > + repeat_phase |= REPEAT_CSE; > + if (insn->cond) > + kill_use(&insn->cond); > } > } Despite redundancy, please include return or break statements in the last case of a switch, to make modifications less error-prone. - Josh Triplett
Attachment:
signature.asc
Description: OpenPGP digital signature
