broken 0 sized memset checks?

[Dave Jones <davej@xxxxxxxxxx>]

I ran sparse over the current linux kernel, and noticed this..

drivers/net/chelsio/sge.c:341:9: warning: memset with byte count of 0
drivers/net/chelsio/sge.c:469:9: warning: memset with byte count of 0

The first..

        q->size = p->freelQ_size[i];
        ....
        size = sizeof(struct freelQ_ce) * q->size;
        q->centries = kmalloc(size, GFP_KERNEL);
        if (!q->centries)
            goto err_no_mem;
        memset(q->centries, 0, size);

Looks valid enough, as does the second..

        q->size = p->cmdQ_size[i];
        ....
        size = sizeof(struct cmdQ_ce) * q->size;
        q->centries = kmalloc(size, GFP_KERNEL);
        if (!q->centries)
            goto err_no_mem;
        memset(q->centries, 0, size);

Sparse bug ?

	Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html