On Sun, 2006-08-13 at 01:51 -0400, Pavel Roskin wrote: > diff --git a/parse.c b/parse.c > index c536ec2..1c9aab8 100644 > --- a/parse.c > +++ b/parse.c > @@ -530,6 +530,8 @@ static const char * handle_attribute(str > return NULL; > if (attribute == &alias_ident) > return NULL; > + if (attribute == &__alias___ident) > + return NULL; > if (attribute == &pure_ident || > attribute == &__pure___ident) > return NULL; > @@ -539,6 +541,8 @@ static const char * handle_attribute(str > return NULL; > if (attribute == &visibility_ident) > return NULL; > + if (attribute == &__visibility___ident) > + return NULL; > if (attribute == &deprecated_ident || > attribute == &__deprecated___ident) > return NULL; Stylistically, it looks like all of the existing ignored keywords in this function use a single combined if condition for the underscored and non-underscored versions of a given keyword, rather than two separate if conditions. For consistency, what about something like the following instead: diff --git a/ident-list.h b/ident-list.h index 95bb96a..ecdce6d 100644 --- a/ident-list.h +++ b/ident-list.h @@ -56,8 +56,8 @@ IDENT(__const); IDENT(__const__); IDENT( IDENT(__noreturn__); IDENT(regparm); IDENT(weak); IDENT(__weak__); IDENT(__no_instrument_function__); IDENT(no_instrument_function); IDENT(__sentinel__); IDENT(sentinel); -IDENT(alias); IDENT(pure); IDENT(always_inline); -IDENT(syscall_linkage); IDENT(visibility); +IDENT(alias); IDENT(__alias__); IDENT(pure); IDENT(always_inline); +IDENT(syscall_linkage); IDENT(visibility); IDENT(__visibility__); IDENT(bitwise); IDENT(__bitwise__); IDENT(model); IDENT(__model__); IDENT(__format_arg__); diff --git a/parse.c b/parse.c index c536ec2..6857541 100644 --- a/parse.c +++ b/parse.c @@ -528,7 +528,8 @@ static const char * handle_attribute(str if (attribute == &weak_ident || attribute == &__weak___ident) return NULL; - if (attribute == &alias_ident) + if (attribute == &alias_ident || + attribute == &__alias___ident) return NULL; if (attribute == &pure_ident || attribute == &__pure___ident) @@ -537,7 +538,8 @@ static const char * handle_attribute(str return NULL; if (attribute == &syscall_linkage_ident) return NULL; - if (attribute == &visibility_ident) + if (attribute == &visibility_ident || + attribute == &__visibility___ident) return NULL; if (attribute == &deprecated_ident || attribute == &__deprecated___ident) - Josh Triplett - To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
