Re: [PATCH RESEND v10 5/5] ASoC: cs40l50: Support I2S streaming to CS40L50

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




> On Apr 14, 2024, at 2:45 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> 
> On Fri, Apr 12, 2024 at 04:40:34PM +0000, James Ogletree wrote:
>> Hi Mark,
>> 
>> All feedback to date has been addressed, and reviews have died down. Is there
>> something more you’d like to see here or discuss before considering ACK'ing this?
>> It will be going in the MFD tree.
> 
> Please don't top post, reply in line with needed context.  This allows
> readers to readily follow the flow of conversation and understand what
> you are talking about and also helps ensure that everything in the
> discussion is being addressed.
> 
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so 
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.
> 
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.

Hi Mark,

This was pure ignorance on my part. In the future I will reply in line with
context. Thank you for the feedback.

Best,
James




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux