wt., 26 paź 2021 o 15:43 Alex Elder <elder@xxxxxxxxxx> napisał(a): > > On 10/25/21 11:31 AM, Janusz Dziedzic wrote: > > From: Alex Elder <elder@xxxxxxxxxx> > > > > Add a prompt to the "tristate" attribute in the Kconfig file in > > which QCOM_QMI_HELPERS is defined; I find it doesn't get selected > > without it. > > This was a *long* time ago! > https://lore.kernel.org/all/20180427140358.30839-1-elder@xxxxxxxxxx/ > > The discussion that followed indicated that the thing that needs > QCOM_QMI_HELPERS should *select* it rather than *depend on it. > > Will this not work for you? > This don't work, we can't run select from backports. Backports drivers - ath11k for this case - build out of the tree as a separate modules. Eg. Today we are using kernel 5.10 and backports generated from kernel 5.15. So our kernel 5.10 don't check CONFIG_ATH11K This is what I see from our kernel: Selected by [n]: ATH11K [=n] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=n] && MAC80211 [=n] && HAS_DMA [=y] && CRYPTO_MICHAEL_MIC [=n] But we build backports/ath11k module which has: depends on QCOM_QMI_HELPERS To enable backports/ath11k build we need kernel that have QCOM_QMI_HELPERS enabled. Because of that we need this configurable. BR Janusz > -Alex > > > We need it in OpenWRT project, when using WiFi backports > > and build ath11k driver. While ath11k driver depends on > > QCOM_QMI_HELPERS we need way to enable this option in > > our kernel. > > > > Signed-off-by: Alex Elder <elder@xxxxxxxxxx> > > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> > > --- > > drivers/soc/qcom/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index fe3c486ae32d..16fb8e286015 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS > > select QCOM_QMI_HELPERS > > > > config QCOM_QMI_HELPERS > > - tristate > > + tristate "Qualcomm QMI Helpers" > > depends on NET > > > > config QCOM_RMTFS_MEM > > > -- Janusz Dziedzic
