Quoting Douglas Anderson (2020-10-14 14:05:23) > diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpasscorecc-sc7180.c > index 48d370e2108e..e12d4c2b1b70 100644 > --- a/drivers/clk/qcom/lpasscorecc-sc7180.c > +++ b/drivers/clk/qcom/lpasscorecc-sc7180.c > @@ -388,6 +388,25 @@ static int lpass_create_pm_clks(struct platform_device *pdev) > return ret; > } > > +static int lpass_core_cc_pm_clk_resume(struct device *dev) > +{ > + struct regmap *regmap = dev_get_regmap(dev, "lpass_core_cc"); Please make "lpass_core_cc" a static const pointer in this driver so that it can be used here and when the regmap is made so that we're certain they match. > + unsigned int l_val; > + int ret; > + > + ret = pm_clk_resume(dev); > + if (ret) > + return ret; > + > + /* If PLL_L_VAL was cleared then we should re-init the whole PLL */ > + regmap_read(regmap, 0x1004, &l_val); > + if (!l_val) > + clk_fabia_pll_configure(&lpass_lpaaudio_dig_pll, regmap, > + &lpass_lpaaudio_dig_pll_config); > + > + return 0; > +} > + > static int lpass_core_cc_sc7180_probe(struct platform_device *pdev) > { > const struct qcom_cc_desc *desc;