Re: [PATCH v1 1/2] clk: qcom: rpmh: skip undefined clocks when registering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Stephen,

Thanks for your review comments.

On 1/2/2020 6:26 AM, Stephen Boyd wrote:
Quoting Taniya Das (2019-12-31 03:00:47)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 7ed313a..05cbe6f 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -462,7 +464,8 @@ static int clk_rpmh_probe(struct platform_device *pdev)

                 ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]);
                 if (ret) {
-                       dev_err(&pdev->dev, "failed to register %s\n", name);
+                       dev_err(&pdev->dev, "failed to register %s\n",
+                                                       hw_clks[i]->init->name);

After register clk_hw::init is NULL. This will probably oops. It would
be better to save off the name before registering.


Will take care in the next patch series.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux