Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Stephen,

On 10/3/2019 9:31 PM, Stephen Boyd wrote:
Quoting Taniya Das (2019-10-03 03:31:15)
Hi Stephen,

On 10/1/2019 8:08 PM, Stephen Boyd wrote:

Why do you want to keep them critical and registered? I'm suggesting
that any clk that is marked critical and doesn't have a parent should
instead become a register write in probe to turn the clk on.

Sure, let me do a one-time enable from probe for the clocks which
doesn't have a parent.
But I would now have to educate the clients of these clocks to remove
using them.

If anyone is using these clks we can return NULL from the provider for
the specifier so that we indicate there isn't support for them in the
kernel. At least I hope that code path still works given all the recent
changes to clk_get().

Could you please confirm if you are referring to update the below?

--- a/drivers/clk/qcom/common.c
+++ b/drivers/clk/qcom/common.c
@@ -218,7 +218,7 @@ static struct clk_hw *qcom_cc_clk_hw_get(struct of_phandle_args *clkspec,
                return ERR_PTR(-EINVAL);

-       return cc->rclks[idx] ? &cc->rclks[idx]->hw : ERR_PTR(-ENOENT);
+       return cc->rclks[idx] ? &cc->rclks[idx]->hw : NULL;

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux