(cc'ing Andy's correct email address) On Wed, May 15, 2019 at 2:46 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Quoting Amit Kucheria (2019-05-13 04:54:12) > > On Mon, May 13, 2019 at 4:31 PM Amit Kucheria <amit.kucheria@xxxxxxxxxx> wrote: > > > > > > On Tue, Jan 15, 2019 at 12:13 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > > > > > The 8 CPU cores of the SDM845 are organized in two clusters of 4 big > > > > ("gold") and 4 little ("silver") cores. Add a cpu-map node to the DT > > > > that describes this topology. > > > > > > This is partly true. There are two groups of gold and silver cores, > > > but AFAICT they are in a single cluster, not two separate ones. SDM845 > > > is one of the early examples of ARM's Dynamiq architecture. > > > > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > > > > > I noticed that this patch sneaked through for this merge window but > > > perhaps we can whip up a quick fix for -rc2? > > > > > > > And please find attached a patch to fix this up. Andy, since this > > hasn't landed yet (can we still squash this into the original patch?), > > I couldn't add a Fixes tag. > > > > I had the same concern. Thanks for catching this. I suspect this must > cause some problem for IPA given that it can't discern between the big > and little "power clusters"? Both EAS and IPA, I believe. It influences the scheduler's view of the the topology. > Either way, > > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Thanks. Andy/Bjorn, can we squeeze this in for -rc2 as a bugfix? Regards, Amit