Hi, On Tue, Nov 20, 2018 at 1:08 PM Sibi Sankar <sibis@xxxxxxxxxxxxxx> wrote: > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > index 14947562bc67..bd9f4882fcf0 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > @@ -75,6 +75,17 @@ on the Qualcomm Hexagon core. > Definition: reference to the regulators to be held on behalf of the > booting of the Hexagon core > > +- power-domains: > + Usage: required Assuming I understand correctly, presumably you want to say that it's required to list _either_ power-domains or supplies. Right now you have the bindings saying that you need both regulators and power-domains on all boards. > + Value type: <phandle> > + Definition: reference to the cx, mx and mss power-domains to be held on > + behalf of the booting the Hexagon core > + > +- power-domain-names: > + Usage: required > + Value type: <stringlist> > + Definition: must be "cx", "mx", "mss" Comparing to the patch you posted at <https://lkml.kernel.org/r/20181127085828.17908-1-sibis@xxxxxxxxxxxxxx>, it seems like maybe you also need "aop" listed here? -Doug
