From: Sunil Kovvuri <sunil.kovvuri@xxxxxxxxx> Date: Sat, 17 Nov 2018 21:42:41 +0530 > On Sat, Nov 17, 2018 at 12:50 PM David Miller <davem@xxxxxxxxxxxxx> wrote: >> >> From: sunil.kovvuri@xxxxxxxxx >> Date: Thu, 15 Nov 2018 16:29:29 +0530 >> >> > From: Stanislaw Kardach <skardach@xxxxxxxxxxx> >> > >> > The resource locks does not need to be a spinlock as they are not >> > used in any interrupt handling routines (only in bottom halves). >> > Therefore relax them into a mutex so that later on we may use them >> > in routines that might sleep. >> > >> > Signed-off-by: Stanislaw Kardach <skardach@xxxxxxxxxxx> >> > Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxxx> >> >> This is confusing because software interrupts are often called bottom >> halves, and in which sleeping and thus mutexes are not allowed. > > Mailbox message interrupt handler schedules workqueue and exits. > Message handling happens in workqueue context, hence moving from > spinlock to mutex. > Hope this clarifies. Fix the commit message like this then.