On Wed, Nov 14, 2018 at 6:48 PM Alex Elder <elder@xxxxxxxxxx> wrote: > > On 11/7/18 9:00 AM, Arnd Bergmann wrote: > > On Wed, Nov 7, 2018 at 1:33 AM Alex Elder <elder@xxxxxxxxxx> wrote: > >> diff --git a/drivers/net/ipa/ipa_reg.c b/drivers/net/ipa/ipa_reg.c > >> new file mode 100644 > >> index 000000000000..5e0aa6163235 > >> --- /dev/null > >> +++ b/drivers/net/ipa/ipa_reg.c > >> @@ -0,0 +1,972 @@ > It may be that this parse/construct mechanism isn't justified > at this point. I thought the way it presented a generic > interface was useful, but with just one (initial) hardware > target we don't (yet) realize its potential benefit. It could > be added back later, as support for new versions is added. > > As of now I don't plan to change this, but if you or someone > else feels it would be better without it I can do that. Fair enough. I do think that it would be better to avoid this, but it's much less important than the other issues I mentioned, so please put this on the bottom of your priorities list, we can talk about it again when we get closer to merging the driver. Arnd