On 09/28/2018 12:21 PM, Bjorn Andersson wrote: >> I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS. I could >> change that to select it instead but I still think this entry >> should be changed. I was thinking one of two changes: - Add the prompt string (which I suggested) - Don't add the prompt, but remove the help and/or add a comment to indicate that the lack of prompt is intentional (because it really looked like an oversight to me) I don't really care though; I'll change my code to select it rather than depend on it. > Why do you say it needs to change? I tested this by just adding a > "select QCOM_QMI_HELPERS" in my client drivers. > >> I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig >> also depends on--rather than selects--QCOM_QMI_HELPERS. >> > That's wrong. Maybe someone else should fix this, but I can do it if you like (and if that's the case, say so). -Alex
