Hi Vikash, Thanks for this new revision. I don't have much to add, apart from maybe a few suggestions to make it easier to follow the "story" this series tells: * Maybe the no_tz member is appearing too early in the series. For the first two patches, we still only support loading the firmware through TrustZone. In patch 3 we initialize no_tz properly, but still cannot boot without TrustZone, which creates a state where the driver could parse the firmware node, but would still attempt to use TrustZone. * I feel like patch 1 should be merged into patch 4, since the function it introduces is not used before patch 4 anyway. If you agree I can maybe do the v9 of the series to address the two points mentioned above, unless Stanimir is already happy with the state? In any case, this is doing the job, so: Tested-by: Alexandre Courbot <acourbot@xxxxxxxxxxxx> On Wed, Sep 19, 2018 at 8:45 AM Vikash Garodia <vgarodia@xxxxxxxxxxxxxx> wrote: > > Ignore the v8 of this series. The code that was modified was added to > wrong > patchset while handling the git rebase. > Please review the version 9. > > On 2018-09-19 03:29, Vikash Garodia wrote: > > This series just fixes the compilation for of_dma_configure. > > Minor #define name improvement and indentations. > > > > Stanimir Varbanov (1): > > venus: firmware: register separate platform_device for firmware > > loader > > > > Vikash Garodia (4): > > venus: firmware: add routine to reset ARM9 > > venus: firmware: move load firmware in a separate function > > venus: firmware: add no TZ boot and shutdown routine > > dt-bindings: media: Document bindings for venus firmware device > > > > .../devicetree/bindings/media/qcom,venus.txt | 13 +- > > drivers/media/platform/qcom/venus/core.c | 24 ++- > > drivers/media/platform/qcom/venus/core.h | 6 + > > drivers/media/platform/qcom/venus/firmware.c | 234 > > +++++++++++++++++++-- > > drivers/media/platform/qcom/venus/firmware.h | 17 +- > > drivers/media/platform/qcom/venus/hfi_venus.c | 13 +- > > drivers/media/platform/qcom/venus/hfi_venus_io.h | 8 + > > 7 files changed, 272 insertions(+), 43 deletions(-)
