Hi, On Thu, Sep 6, 2018 at 1:12 PM, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: >> * Seems to have a few rails named differently LDO22 is named >> "vreg_l22a_2p95" in your DTS but "vreg_l22a_2p85" in mine as one >> example. The schematics I have (from Dec 5, 2017) show it as 2p85. >> > > Looks like a typo on my part, yours matches the schematics I have as > well. OK. That was just one example. Maybe do a diff of the two and see if you find any where you believe your patch was right and mine was wrong. >> * Is lacking many alternate names for rails. We can debate this also >> if you want. >> > > Afaict names such as "vdda_pcie_1p2" is the name of the pin on the > SDM845, while the thing that comes out of the regulator is named > vreg_l26a_1p2. > > So I believe this name should be used in the pcie node as: > > vdda_pcie_1p2-supply = <&vreg_l26a_1p2>; Adding labels for things like "vdda_pcie_1p2" is based on a suggestion Stephen Boyd made to me that he felt it would be nice to be able to refer to things by the name of the supply pin on the SoC. This could possibly enable better sharing of device tree snippets between different boards using the same SoC and the idea seemed sane to me, so I implemented it. I described it in my commit message like this: - Regulators that are hooked up to supply pins on the SoC are given an alias matching the name of that pin (pin name comes from the Qualcomm SoC "device specification" doc). If folks don't like it, though, it's easy to remove. >> * Have a few voltage values different. If you have better info than >> me we should update to yours. Diffing against yours does make me >> believe that perhaps LDO14 should be listed as 1.88 V in my patch. >> > > Downstream it's listed as min: 1.8V max: 1.88V init: 1.8V. I can change mine to that. It's a very strange specification though. Is it really 1.80 - 1.88 V? Does something out there actually need the voltage to be variable in this small range? >> * Is lacking pm8005. >> > > I didn't need this, yet... OK. I can certainly remove it as needed--the downstream patch I started with had it so I figured I'd keep it in. -Doug
