On Thu 30 Nov 00:18 PST 2017, Philippe Ombredanne wrote: > Bjorn, > > On Thu, Nov 30, 2017 at 2:16 AM, Bjorn Andersson > <bjorn.andersson@xxxxxxxxxx> wrote: > [] > > diff --git a/drivers/soc/qcom/qmi_interface.c b/drivers/soc/qcom/qmi_interface.c > > new file mode 100644 > > index 000000000000..4027b52b0834 > > --- /dev/null > > +++ b/drivers/soc/qcom/qmi_interface.c > > @@ -0,0 +1,857 @@ > > +/* > > + * Copyright (C) 2017 Linaro Ltd. > > + * > > + * This software is licensed under the terms of the GNU General Public > > + * License version 2, as published by the Free Software Foundation, and > > + * may be copied, distributed, and modified under those terms. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > Could it make sense, especially for new files, to use the new SPDX ids > and avoid adding boilerplate that will need to be cleaned up later? > e.g. something like this instead, using the new conventions started by > greg-kh and by documented tglx? > > NB: the // comment style is not a mistake and is what Linus wants > there. See the threads on this topic. > > > @@ -0,0 +1,857 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2017 Linaro Ltd. > > + */ > > Isn't this shorter and better? :P > That sounds very reasonable, I will update the patches. > BTW, if you need help to fix this on the rest of Linaro contributed > code, I maintain a tool that can help there. > I haven't seen any guidelines on how this should be introduced throughout the kernel, should I make a similar push for the subsystems I maintain? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
