On 01/05/2017 07:50 PM, Andy Gross wrote:
On Thu, Jan 05, 2017 at 02:25:25PM +0530, Vivek Gautam wrote:
Assign num_parents as 0 while registering fixed rate clocks
in _qcom_cc_register_board_clk(), to make sure the clk framework
doesn't dereference parent.
Fixes: ee15faffef11 ("clk: qcom: common: Add API to register board clocks backwards compatibly")
Cc: Georgi Djakov<georgi.djakov@xxxxxxxxxx>
Signed-off-by: Vivek Gautam<vivek.gautam@xxxxxxxxxxxxxx>
---
Based on 'clk-next'. Build tested.
drivers/clk/qcom/common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index cfab7b400381..df004ead1bef 100644
--- a/drivers/clk/qcom/common.c
+++ b/drivers/clk/qcom/common.c
@@ -157,6 +157,7 @@ static int _qcom_cc_register_board_clk(struct device *dev, const char *path,
init_data.name = path;
init_data.ops = &clk_fixed_rate_ops;
+ init_data.num_parents = 0;
It seems like there was a initializer in the declaration but it was { } instead
of { 0 }.
Was the original intent to make this structure initialized to 0? If so, perhaps
it should be fixed above in the initializer.
yes, i think we intend to initialize the clock init data to 0, and thus
we should do that during declaration.
Will modify and re-spin the patch.
Regards
Vivek
ret = devm_clk_hw_register(dev, &fixed->hw);
if (ret)
Regards,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message tomajordomo@xxxxxxxxxxxxxxx
More majordomo info athttp://vger.kernel.org/majordomo-info.html
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
