On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
> >On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> >
> >>From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> >>
> >>Add SMEM and TCSR DT nodes on MSM8996.
> >>
> >>Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> >>Signed-off-by: Sarangdhar Joshi <spjoshi@xxxxxxxxxxxxxx>
> >>---
> >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >>diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>index 949b096..0a810f5 100644
> >>--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>@@ -169,12 +169,31 @@
> >> method = "smc";
> >> };
> >>
> >>+ smem {
> >>+ compatible = "qcom,smem";
> >>+
> >>+ memory-region = <&smem_mem>;
> >>+
> >>+ hwlocks = <&tcsr_mutex 3>;
> >>+ };
> >>+
> >> soc: soc {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> ranges = <0 0 0 0xffffffff>;
> >> compatible = "simple-bus";
> >>
> >>+ tcsr_mutex_regs: syscon@740000 {
> >>+ compatible = "syscon";
> >>+ reg = <0x740000 0x20000>;
> >>+ };
> >>+
> >>+ tcsr_mutex: hwlock {
> >>+ compatible = "qcom,tcsr-mutex";
> >>+ syscon = <&tcsr_mutex_regs 0 0x1000>;
> >>+ #hwlock-cells = <1>;
> >>+ };
> >
> >Sorry, I got this in the wrong place, the hwlock node should sit outside
> >of soc {} - looks like we got this wrong in msm8916 as well.
>
> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
> root)?
Yes. Any node that doesn't have reg properties should go under the root.
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
