Re: [PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 08/18/2016 03:10 PM, Linus Walleij wrote:
On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
<jacek.anaszewski@xxxxxxxxx> wrote:

+                               led@48 {
+                                       /*
+                                        * The keypad LED @0x48 is routed
to
+                                        * the sensor board where it is
+                                        * connected to an infrared LED
+                                        * SFH4650 (60mW, @850nm) next to
the
+                                        * ambient light and proximity
sensor
+                                        * Capella Microsystems CM3605.
+                                        */
+                                       compatible =
"qcom,pm8058-keypad-led";
+                                       reg = <0x48>;
+                                       label = "proximity0";


In DT bindings documentation it was changed to "pm8050:white:keypad" to
adhere to the LED class device naming convention. I assume that having
it in this form is an omission here.

Hm right. Given the usecase here, what do you say about naming
it:

"pm8058:infrared:proximitysensor"

Looks good.

--
Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux