On 07/19/2016 06:51 AM, Neil Armstrong wrote: > diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c > index 795fcbd..976f5f6 100644 > --- a/drivers/rtc/rtc-pm8xxx.c > +++ b/drivers/rtc/rtc-pm8xxx.c > @@ -393,6 +393,16 @@ static int pm8xxx_rtc_enable(struct pm8xxx_rtc *rtc_dd) > return 0; > } > > +static const struct pm8xxx_rtc_regs pm8018_regs = { > + .ctrl = 0x11d, > + .write = 0x11f, > + .read = 0x123, > + .alarm_rw = 0x127, > + .alarm_ctrl = 0x11d, > + .alarm_ctrl2 = 0x11e, > + .alarm_en = BIT(1), > +}; This is the same as pm8921_regs, so why do we need to duplicate it? Can't we point the new compatible at the same data? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html