On 29/05/2020 14:39, Vineet Gupta wrote: > On 5/29/20 5:58 AM, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 28/05/2020 16:43, Vineet Gupta wrote: >>> The existing macros are fragile and expect local variables with a >>> certain name. Fix this by defining them as functions with defaul >>> timplementation in a new header dl-runtime.h which arches can overrid >>> eif need be. >>> >>> This came up during ARC port review. >>> >>> This patch potentially only affects hppa/x86 ports, >>> build tested for both those configs and a few more. >>> >>> Suggested-by: Adhemerval Zanella <adhemerval.zanella@xxxxxxxxxx> >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@xxxxxxxxxx> > > Sorry I didn't think through this before, but ARC port needs pltgot arg (runtime > address of plt0) in reloc_index not reloc_offset. I'll swap them and repost. Hum I though I had it covered on my suggestion, but it seems I mixed them up. Ok, I will review the new version. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-snps-arc
