Re: [PATCH] auto filter aio tests of libc can't support aio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vineet,

> uClibc-ng lacks libaio.h and thus LTP UCLIBC=1 builds need to filter
> out aio tests which it currently doesn't.

> FWIW the tests sources themselves use a slightly different guard
> HAVE_LIBAIO (while autotool generate HAVE_LIBAIO_H).
> Anyhow that seems pointless as aio tests should not even build of libc
> doesn't support the prerequsute header.

> Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>
> ---
>  testcases/kernel/io/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)

> diff --git a/testcases/kernel/io/Makefile b/testcases/kernel/io/Makefile
> index 7db02882a530..3afae3888f63 100644
> --- a/testcases/kernel/io/Makefile
> +++ b/testcases/kernel/io/Makefile
> @@ -24,4 +24,8 @@ top_srcdir		?= ../../..

>  include $(top_srcdir)/include/mk/env_pre.mk

> +ifndef HAVE_LIBAIO_H
> +FILTER_OUT_DIRS	+= aio
> +endif
This is IMHO wrong, as all files using libaio.h are guarded with
TST_TEST_TCONF().


Kind regards,
Petr

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-snps-arc



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux