On 1/28/19 11:27 PM, Alexey Brodkin wrote: > Hi Vineet, > >> -----Original Message----- >> From: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx> >> Sent: Wednesday, January 16, 2019 2:30 PM >> To: linux-snps-arc@xxxxxxxxxxxxxxxxxxx; Vineet Gupta <vgupta@xxxxxxxxxxxx> >> Cc: linux-kernel@xxxxxxxxxxxxxxx; Alexey Brodkin <abrodkin@xxxxxxxxxxxx>; Eugeniy Paltsev >> <Eugeniy.Paltsev@xxxxxxxxxxxx> >> Subject: [PATCH 1/2] ARCv2: Enable unaligned access in early ASM code >> >> Even though we do enable AD bit in arc_init_IRQ() we need to do >> it in early ASM code otherwise we may face unaligned data until >> we reach arc_init_IRQ() because GCC starting from v8.1.0 actively >> generates unaligned data as it assumes that: >> * ARCv2 always has support of unaliged data >> * This support is turned on in runtime >> >> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx> > I remember you wanted to have a Kconfig toggle for unaligned access support > but since this commit is more of a fix for existing (always enabling) > implementation and so I propose to accept is as it is and moreover backport > to stable kernels. > > And in the separate change introduce discussed Kconfig toggle so we may test > RTL with unaligned support disabled. > > Sounds good? Fair enough. And to avoid backport merge conflicts we need to keep the redundant AD bit setting in intc-arcv2.c and rework in Eugeniy's series. -Vineet _______________________________________________ linux-snps-arc mailing list linux-snps-arc@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-snps-arc
