On 12/18/18 4:01 PM, Joseph Myers wrote: > On Tue, 18 Dec 2018, Joseph Myers wrote: > >> On Tue, 18 Dec 2018, Vineet Gupta wrote: >> >>> +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) >> Missing spaces before '(' (should have such spaces in most cases between >> an identifier or keyword and '(' - calls to "defined", calls to functions, >> calls to macros, __attribute__, etc. - except for a few cases of calls to >> macros such as ElfW where the result is logically used like an >> identifier). > Or, of course, just omit the parentheses in the "defined" case, which is > very common for calls to "defined" in glibc. > > (Function-like macro definitions are a case where you *can't* have the > space because the syntax of C requires no space between the name of the > macro being defined and the '(' before the list of argument names.) Ok, done ! _______________________________________________ linux-snps-arc mailing list linux-snps-arc@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-snps-arc