Hi Martin, On Thu, 2018-11-15 at 10:27 +0100, Martin Jansa wrote: > On Thu, Nov 15, 2018 at 05:15:03AM +0000, Alexey Brodkin wrote: > > Hi Marek, [snip] > > > Reviewed-by: Marek Vasut <marex at denx.de> > > > > > > That said, could the recipe for mkimage and mkenvimage be somehow > > > deduplicated ? There seems to be a lot of common stuff. > > > > I'd say why don't we just have one recipe for all U-Boot tools > > instead of adding tools one-by-one? > > Or add: > install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage > ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage > > to existing u-boot-mkimage recipe, that's what I'm doing in > u-boot-mkimage bbappend. Sure and indeed that was my initial intention but then I noticed there're separate recipes for mkimage and fw-utils and decided to act similarly. If OE people is fine with addition of another (pretty similar ideologically) utility in u-boot-mkimage_xx.bb then I'm happy to implement it that way. -Alexey