On Fri, Mar 23, 2018 at 12:06:18PM -0700, Matthew Wilcox wrote: > On Fri, Mar 23, 2018 at 02:00:24PM -0400, Rich Felker wrote: > > On Fri, Mar 23, 2018 at 05:48:06AM -0700, Matthew Wilcox wrote: > > > On Thu, Mar 22, 2018 at 07:36:36PM +0300, Ilya Smith wrote: > > > > Current implementation doesn't randomize address returned by mmap. > > > > All the entropy ends with choosing mmap_base_addr at the process > > > > creation. After that mmap build very predictable layout of address > > > > space. It allows to bypass ASLR in many cases. This patch make > > > > randomization of address on any mmap call. > > > > > > Why should this be done in the kernel rather than libc? libc is perfectly > > > capable of specifying random numbers in the first argument of mmap. > > > > Generally libc does not have a view of the current vm maps, and thus > > in passing "random numbers", they would have to be uniform across the > > whole vm space and thus non-uniform once the kernel rounds up to avoid > > existing mappings. > > I'm aware that you're the musl author, but glibc somehow manages to > provide etext, edata and end, demonstrating that it does know where at > least some of the memory map lies. Yes, but that's pretty minimal info. > Virtually everything after that is > brought into the address space via mmap, which at least glibc intercepts, There's also vdso, the program interpreter (ldso), and theoretically other things the kernel might add. I agree you _could_ track most of this (and all if you want to open /proc/self/maps), but it seems hackish and wrong (violating clean boundaries between userspace and kernel responsibility). > > Also this would impose requirements that libc be > > aware of the kernel's use of the virtual address space and what's > > available to userspace -- for example, on 32-bit archs whether 2GB, > > 3GB, or full 4GB (for 32-bit-user-on-64-bit-kernel) is available, and > > on 64-bit archs where fewer than the full 64 bits are actually valid > > in addresses, what the actual usable pointer size is. There is > > currently no clean way of conveying this information to userspace. > > Huh, I thought libc was aware of this. Also, I'd expect a libc-based > implementation to restrict itself to, eg, only loading libraries in > the bottom 1GB to avoid applications who want to map huge things from > running out of unfragmented address space. That seems like a rather arbitrary expectation and I'm not sure why you'd expect it to result in less fragmentation rather than more. For example if it started from 1GB and worked down, you'd immediately reduce the contiguous free space from ~3GB to ~2GB, and if it started from the bottom and worked up, brk would immediately become unavailable, increasing mmap pressure elsewhere. Rich
