On 10/01/18 15:26, Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 02:56:01PM +0000, Robin Murphy wrote: >> I took a look at these, and it seems their phys_to_dma() usage is doing the >> thing which we subsequently formalised as dma_map_resource(). I've had a >> crack at a quick patch to update the CESA driver; qcom_nandc looks slightly >> more complex in that the changes probably need to span the BAM dmaengine >> driver as well. > > Sounds great, although probably something for the next merge window. > > In the meantime does this patch looks good to you? Yes indeed, modulo Vladimir's comments - it does seem prudent to fix the obvious off-by-ones as we touch them. I've wanted to do something like this for ages, but never got around to it myself. Thanks, Robin.