[PATCH v2] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/22/2018 07:28 AM, Shawn Lin wrote:
>>
>> Lets cast this multiply to u64 type which prevents overflow.
>>
>> Tested-by: Vineet Gupta <Vineet.Gupta1 at synopsys.com>
>> Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files
>>
>> Signed-off-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com>
>>
>> CC: Alexey Brodkin <abrodkin at synopsys.com>
>> CC: Eugeniy Paltsev <paltsev at synopsys.com>
>> CC: Douglas Anderson <dianders at chromium.org>
>> CC: Ulf Hansson <ulf.hansson at linaro.org>
>> CC: linux-kernel at vger.kernel.org
>> CC: linux-snps-arc at lists.infradead.org
>> Cc: <stable at vger.kernel.org> #? 9d9491a7da2a mmc: dw_mmc: Fix the DTO timeout 
>> calculation
> 
> The fix looks good to me, but the tags should be improved a bit:
> 
> Fixes: 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation")

Ok, then perhaps use Reported-by tag to call out when/how issue was found.

Reported-by: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files

> Cc: <stable at vger.kernel.org>
> 
> Otherwise,
> Reviewed-by: Shawn Lin <shawn.lin at rock-chips.com>





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux