Hi Michal, On Tue, Feb 20, 2018 at 12:27 PM, Michal Simek <michal.simek at xilinx.com> wrote: > On 20.2.2018 11:38, Geert Uytterhoeven wrote: >> On Tue, Feb 20, 2018 at 11:22 AM, Michal Simek <michal.simek at xilinx.com> wrote: >>> On 20.2.2018 10:40, Geert Uytterhoeven wrote: >>>> The cdns_uart_port[] array is indexed using a value derived from the >>>> "serialN" alias in DT, which may lead to an out-of-bounds access. >>>> >>>> Fix this by adding a range check. > I have checked 4 patches I have sent in past which didn't reach mainline > (probably because of RFC) > Take a look at > https://www.spinics.net/lists/linux-serial/msg27106.html > > I have removed cdns_uart_port array completely there. Nice! I'd love to get rid of fixed arrays in serial... However, IMHO it's still worthwhile to fix the out-of-bounds access first, as that fix can be backported to stable kernels easily. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
