Hi Randy, thanks for comments, will be fixed in patch V2. On Thu, 2018-08-23 at 08:08 -0700, Randy Dunlap wrote: > On 08/23/2018 08:00 AM, Eugeniy Paltsev wrote: > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > > index 71c0ab46f216..0f9cc1582cab 100644 > > --- a/drivers/gpio/Kconfig > > +++ b/drivers/gpio/Kconfig > > @@ -430,6 +430,15 @@ config GPIO_REG > > A 32-bit single register GPIO fixed in/out implementation. This > > can be used to represent any register as a set of GPIO signals. > > > > +config GPIO_SNPS_CREG > > + bool "GPIO via CREG (Control REGisers) driver" > > REGisters) > > > + select OF_GPIO > > + help > > + This driver supports GPIOs via CREG on various Synopsys SoCs. > > + This is is single-register MMIO gpio driver for complex cases > > This is a MMIO GPIO > > > + where only several fields in register belong to GPIO and > > in a register > > > + each GPIO owns field with different length and on/off values. > > maybe: > fields with different lengths > > > + > > config GPIO_SPEAR_SPICS > > bool "ST SPEAr13xx SPI Chip Select as GPIO support" > > depends on PLAT_SPEAR > > -- Eugeniy Paltsev