On 09/03/17 09:47, Rafa? Mi?ecki wrote: > From: Rafa? Mi?ecki <rafal at milecki.pl> > > Printing with pr_* functions requires adding line break manually. > > Signed-off-by: Rafa? Mi?ecki <rafal at milecki.pl> I've had a quick look over and there are no obvious errors. I wonder if the of_iomap() and related calls should print an error if they fail as all the examples here are of the form of: ptr = of_iomap(reource) if (!ptr) { pr_err("cannot remap resource\n"); ... return ERR; } Maybe we should look into this post this patch series. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius