On 11/01/2016 06:03 PM, Vineet Gupta wrote: >>> Because of the git mv you, diff didn't include bulk of driver code which would >>> >> make for bulk of review anyways. So perhaps in v2 I don't do the git mv. OK ? >> > >> > That means I will review and comment existing code. It is not a problem for me >> > if you agree to do the changes. > Sure, the whole point is to make things better as an outcome of review. I have no > issues changing code provided we don't add major performance regressions. So just wondering if I could have some comments on the initial import of driver before I send out a v2. The issue is git mv didn't show bulk of code being moved. Shall I send a v2 with a different ordering so I introduce the driver first, with new headers, new Kconfig items etc and then as a subsequent patch prune those bits from arch/arc/* ? -Vineet
