Hi Arnd and Bjorn, On 2/3/2016 9:01 PM, Arnd Bergmann wrote: > On Wednesday 03 February 2016 12:38:44 Bjorn Helgaas wrote: >> On Wed, Feb 03, 2016 at 06:12:00PM +0000, Joao Pinto wrote: >> >>> - replace "snps,pcie-synopsys" for "snps,pcie-synopsys-ipk"? >> >> This is a question for Arnd. >> >>> - rename the driver to pcie-synopsys-ipk? >> >> It doesn't seem necessary to me to include both "synopsys" and "ipk" in the >> filename and the driver name. Take a look at what the existing drivers do, >> and do something similar. > > The "synopsys" can go away, it's already in the vendor field of the > string. "ipk" is still a bit unspecific, I was hoping to see a specific > chip and/or version of the PCIe part. Something like > > compatible = "snps,ipk2040-pcie", "snps,ipk-pcie", "snps,dw-pcie-1.23", "snps,dw-pcie"; > > which would indicate that there is a chip called "ipk2040" in a family called "ipk", > and this includes the designware pcie implementation in version 1.23. > "snps,dw-pcie" seems a good idea! >>> - update the devicetree documentation referring that the ranges also include the >>> config space >> >> Another one for Arnd. > > This one is wrong, the ranges should *not* include the config space, and if they > currently do, you must change the driver. The generic dw-pcie driver still > accepts the config space in the ranges for backwards compatibility with some > of the earlier front-ends that mistakenly did this, but new driver should not > do the same, and we should probably add some code in the common driver to > prevent it for front-ends other than the ones we have to keep compatibility with. > I am going to remove the config space from the ranges and test the driver. > Arnd > Thanks.
