On Tue, Feb 02, 2016 at 09:25:25PM +0100, Arnd Bergmann wrote:
> On Monday 01 February 2016 18:07:45 Joao Pinto wrote:
> > +static void synopsys_pcie_establish_link(struct pcie_port *pp)
> > +{
> > + int retries = 0;
> > +
> > + /* check if the link is up or not */
> > + for (retries = 0; retries < 10; retries++) {
> > + if (dw_pcie_link_up(pp)) {
> > + dev_info(pp->dev, "Link up\n");
> > + return;
> > + }
> > + mdelay(100);
> > + }
> > +}
>
> That mdelay() needs to be an msleep(). You should never waste
> a whole second worth of CPU time in a driver.
There are six other copies of this code, and two of them (exynos and
spear) have the same problem.
Bjorn
