On 04/04, Jose Abreu wrote: > >> + fbdiv = i2s_pll_get_value(readl((void *)PLL_FBDIV_ADDR)); > >> + odiv = i2s_pll_get_value(readl((void *)PLL_ODIV0_ADDR)); > >> + > >> + return (((clk->ref_clk / idiv ) * fbdiv) / odiv); > > Again, too many parentheses. Also, any concerns of 32-bit > > truncation here (i.e. is 64-bit math needed)? > > You are right there is no need to use 64-bit math, will change in next version. Well it wasn't 64-bit math in the first place, so the question was more if you wanted to use 64-bit math. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project