On 04/11, Alexey Brodkin wrote: > On Mon, 2016-04-11 at 11:41 +0100, Jose Abreu wrote: > > + * warranty of any kind, whether express or implied. > > + */ > > + > > +#include <linux/platform_device.h> > > +#include <linux/module.h> > > +#include <linux/clk-provider.h> > > +#include <linux/err.h> > > +#include <linux/device.h> > > "linux/platform_device.h" includes "linux/device.h" so you may make this list of headers > a little bit shorter. > > > +#include <linux/of_address.h> > > +#include <linux/slab.h> > > +#include <linux/of.h> > > "linux/of_address.h" already includes "linux/of.h". It's ok to include things twice. In fact, its better to avoid any implicit includes so that if we ever want to remove includes from other headers we can do so without disturbing this driver. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
