On Thu, May 27, 2021 at 01:49:42PM +0200, Thomas Gleixner wrote: > That works, but TBH, it's a hack.... Yeah, it restores to the previous behavior. > What I really fail to understand is how disabling that LVT entry makes > the machine lock up. The observation is is that on James' box, *sometimes* - not always - it would softlockup on CPU0 without this early LVT thermal read. I can try to reproduce on the box I have here, lemme see... > Also if disabling this entry is causing the BIOS/SMM gunk to go south, then > disabling CONFIG_X86_THERMAL_VECTOR should have the same effect. > > Which made me look at other places like lapic_suspend/resume which does > the save/restore Kconfig conditional as well. The fact that it doesn't reproduce always shows that there's something else at play too. As I said in the commit message: "Those soft lockups are not 100% reproducible and the reason for that can only be speculated as no one tells you what SMM does." -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette