On 2024/8/25 16:49, Huang, Kai wrote:
Hi Yuli,
When Thomas pointed out the "Signed-off-by chain is invalid" in v2:
https://lore.kernel.org/all/87zfpx4a0q.ffs@tglx/T/#mdc19b00c10177f3add9deaf505211bf8b3ec7110
I think it meant you either need to have a Co-developed-by for Zelong Xiang,
or you should remove his/her SoB. The reason is the patch is from you, but
not Zelong.
The SoB chain needs to reflect the chronological history of this patch.
I get it now.
It's easy for this aspect to be overlooked or compromised when a patch
is passed around among different developers.
Your rigorous approach is truly admirable.
E.g.,
the SoB chain:
From: You
Co-developed-by: Zelong
Signed-off-by: Zelong
Signed-off-by: You
.. means the patch was originally generated by you, but Zelong also
participated in developing this patch before you finally signed off it.
For this one line code change patch, it doesn't make a lot sense to have
multiple developers, so I think you can just remove Zelong's SoB.
Since the goal is to ensure the SoB chain is as authentic as
possible,there's no need to delete it unless the chain is unreasonably long.
I'll send a patch-v4 to fix it.
Thanks
--
WangYuli
