On Wed, 2024-07-31 at 11:22 +0800, WangYuli wrote: > On 2024/7/30 19:57, Huang, Kai wrote: > > > +linux-sgx list, Jarkko, Haitao. > > > > This message is only printed when SGX is reported in CPUID but is not > > enabled in the FEAT_CTL MSR. I can only recall this can happen when the > > BIOS actually provides an option for the user to turn on/off SGX, in > > which case the current message is correct. > > > > I could be wrong, but I don't recall I have met any machine that doesn't > > have any SGX option in the BIOS but still reports SGX in the CPUID. Can > > you confirm this is the case? > > Sure. > > For example, Lenovo ThinkPad T480s that compliance id is TP00092A. > > Fair enough. I guess the updated message is slightly better: Acked-by: Kai Huang <kai.huang@xxxxxxxxx> Btw, I think there are some issues in the patch title/changelog. Please fix them. E.g., I think the format of patch title should be: x86/cpu: ... In the changelog please avoid using "we", and please use imperative mode to describe the change. More information please see: https://docs.kernel.org/process/maintainer-tip.html