On Tue, 2024-07-30 at 10:56 -0700, Sean Christopherson wrote: > On Tue, Jul 30, 2024, Kai Huang wrote: > > On Tue, 2024-07-30 at 10:49 +0800, WangYuli wrote: > > > When SGX is not supported by the BIOS, we still output the error > > > 'SGX disabled by BIOS', which can be confusing since there might not be > > > an SGX-related option in the BIOS settings. > > > > +linux-sgx list, Jarkko, Haitao. > > > > This message is only printed when SGX is reported in CPUID but is not > > enabled in the FEAT_CTL MSR. I can only recall this can happen when the > > BIOS actually provides an option for the user to turn on/off SGX, in > > which case the current message is correct. > > FWIW, this could easily happen with a virtual machine, e.g. running an old QEMU > with `-cpu host`. > Hmm.. it appears so, if the old Qemu doesn't have SGX support. Thanks. Perhaps "SGX disabled or unsupported by BIOS." or "SGX not enabled by BIOS" is slightly better than the current "SGX disabled by BIOS", but I am not sure whether it is worth patching.