On 3/30/24 04:23, Jarkko Sakkinen wrote: >>> I also wonder is cgroup-tools dependency absolutely required or could >>> you just have a function that would interact with sysfs? >> I should have checked email before hit the send button for v10 🙂. >> >> It'd be more complicated and less readable to do all the stuff without the >> cgroup-tools, esp cgexec. I checked dependency, cgroup-tools only depends >> on libc so I hope this would not cause too much inconvenience. > As per cgroup-tools, please prove this. It makes the job for more > complicated *for you* and you are making the job more complicated > to every possible person in the planet running any kernel QA. I don't see any other use of cgroup-tools in testing/selftests. I *DO* see a ton of /bin/bash use though. I wouldn't go to much trouble to make the thing ash-compatible. That said, the most important thing is to get some selftests in place. If using cgroup-tools means we get actual, runnable tests in place, that's a heck of a lot more important than making them perfect. Remember, almost nobody uses SGX. It's available on *VERY* few systems from one CPU vendor and only in very specific hardware configurations.
