On 10/6/22 13:37, Fabio M. De Francesco wrote: > kmap() were not suited in those cases because it might sleep. If the intents > of the author are simply map a page while in atomic, so to avoid sleeping in > atomic bugs, your conversions looks good. > > For the reasons above, can you please say something more about why this code > needed a kmap_atomic() instead of calling kmap()? This question is backwards. kmap_atomic() is the default that folks use. You use kmap_atomic() *always* unless you _need_ to sleep or one of the other kmap()-only things. Folks don't and shouldn't have to explain why this was using kmap_atomic().