Re: [PATCH RESEND v6 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 29, 2022 at 09:27:08AM +0800, Zhiquan Li wrote:
> 
> On 2022/8/28 05:47, Jarkko Sakkinen wrote:
> >> -	struct sgx_encl_page *encl_owner;
> >> +	union {
> >> +		struct sgx_encl_page *encl_owner;
> >> +		/* Use when SGX_EPC_PAGE_KVM_GUEST set in ->flags: */
> >> +		void __user *vepc_vaddr;
> > Revisiting this, I'd tend to think that simple
> > "void *owner" would be less complicated option
> > than this.
> > 
> > Thoughts?
> > 
> > BR, Jarkko
> > 
> 
> Thanks for your thought, Jarkko.
> 
> The reason is in the reply of patch 01, let's discuss it there.
> 
> Best Regards,
> Zhiquan

OK, it's cool, the problem was in the commit message.

BR, Jarkko



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux