On Mon, Aug 29, 2022 at 09:23:48AM +0800, Zhiquan Li wrote: > > On 2022/8/28 11:27, Jarkko Sakkinen wrote: > > On Sat, Aug 27, 2022 at 12:05:01AM +0800, Zhiquan Li wrote: > >> In order to describe the purpose of 'owner' field more exactly, > >> rename the 'owner' field of struct sgx_epc_page as 'encl_owner', > >> and update all of references. > >> > >> Signed-off-by: Zhiquan Li <zhiquan1.li@xxxxxxxxx> > > Is this rename really worth of doing? I'd only consider > > such if there was two 'owner' fields but since there is > > no name collision, why bother? > > > > Thoughts? Please correct me if I've forgot something > > essential previously discussed. > > > > BR, Jarkko > > > > > > Hello Jarkko, > > The field name and union comes from Dave's suggestion: > > https://lore.kernel.org/linux-sgx/Yrf27fugD7lkyaek@xxxxxxxxxx/T/#m2ff4778948cdc9ee65f09672f1d02f8dc467247b > > - If the rename make the thing complicated we can consider drop this patch, it might introduce potential conflict with the SGX patches under reviewing. > - If you think the union introduced by patch 02 is also unnecessary, then we need to discuss it with Dave. > > Best Regards, > Zhiquan "In order to avoid unnecessary casting" might then be a better way to start the sentence. BR, Jarkko
