Re: [PATCH 2/2] selftests/sgx: Add SGX selftest augment_via_eaccept_long

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 16, 2022 at 09:35:27PM -0700, Reinette Chatre wrote:
> >>> This portion below was also copied from previous test and by only
> >>> testing a write to the first page of the range the purpose is not
> >>> clear. Could you please elaborate if the intention is to only test
> >>> accessibility of the first page and why that is sufficient?
> >>
> >> It is sufficient because the test reproduces the bug. It would have to be
> >> rather elaborated why you would possibly want to do more than that.
> 
> That is fair. An accurate comment (currently an inaccurate copy&paste) would
> help to explain this part of the test.

I would simply add something like:

/* 
 * Define memory pool size big enough to trigger the reclaimer in the EAUG
 * path of the page reclaimer.
 */

Suggestions/edits obviously welcome for the comment.

BR, Jarkko



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux