On Wed, 2022-06-08 at 11:26 +0800, Zhiquan Li wrote: > --- a/arch/x86/kernel/cpu/sgx/main.c > +++ b/arch/x86/kernel/cpu/sgx/main.c > @@ -715,6 +715,8 @@ int arch_memory_failure(unsigned long pfn, int flags) > struct sgx_epc_page *page = sgx_paddr_to_page(pfn << PAGE_SHIFT); > struct sgx_epc_section *section; > struct sgx_numa_node *node; > + int ret = 0; > + unsigned long vaddr; Please switch the order of the two variables so all of variables are in reverse Christmas style. -- Thanks, -Kai