On Fri, Apr 01, 2022 at 10:24:01PM +0800, Cathy Zhang wrote: > Provide non-NULL owner for VA page, which tells that the EPC page is > allocated for use. > > Signed-off-by: Cathy Zhang <cathy.zhang@xxxxxxxxx> So here the code change does not look all that bad but the commit message completely explanation of it. "Provided non-NULL owner" is not something that I can map to any reasonable action that , i.e. I don't know what the heck it even means :-) It's just jargon, isn't it? Staart with "Make epc->owner type-agnostic by changing it's type to `void *`. ..." Then you should answer exactly two questions in the commit message: * Who is the owner? For regular pages it's the logical enclave page. * For exactly what use it is allocated for? BR, Jarkko
