On Mon, Feb 07, 2022 at 04:45:43PM -0800, Reinette Chatre wrote: > + addr = mmap((void *)self->encl.encl_base + total_size, PAGE_SIZE, > + PROT_READ | PROT_WRITE | PROT_EXEC, > + MAP_SHARED | MAP_FIXED, self->encl.fd, 0); Maybe inline comment to just state that this is expected to work because the range does not contain enclave pages, just as a reminder (had xref to sgx_encl_may_map() to check this assumption). Otherwise, fine. BR, Jarkko
