On 2/10/22 3:41 PM, Muhammad Usama Anjum wrote:
On 2/11/22 1:51 AM, Shuah Khan wrote:
On 2/10/22 12:06 PM, Muhammad Usama Anjum wrote:
CC can have multiple sub-strings like "ccache gcc". Erorr pops up if
it is treated as single string and double quote are used around it.
This can be fixed by removing the quotes and not treating CC a single
string.
Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture
detection")
Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
---
tools/testing/selftests/x86/check_cc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/check_cc.sh
b/tools/testing/selftests/x86/check_cc.sh
index 3e2089c8cf549..aff2c15018b53 100755
--- a/tools/testing/selftests/x86/check_cc.sh
+++ b/tools/testing/selftests/x86/check_cc.sh
@@ -7,7 +7,7 @@ CC="$1"
TESTPROG="$2"
shift 2
-if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
+if $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
echo 1
else
echo 0
The intent is testing if $CC is set. Does this change work when
$CC is not set?
Yeah, it works. I've added a debug variable inside sgx/Makefile and it
is detecting empty argument correctly as well.
Sounds good.
thanks,
-- Shuah
